• Liping Zhang's avatar
    netfilter: nft_chain_route: re-route before skb is queued to userspace · d1a6cba5
    Liping Zhang authored
    Imagine such situation, user add the following nft rules, and queue
    the packets to userspace for further check:
      # ip rule add fwmark 0x0/0x1 lookup eth0
      # ip rule add fwmark 0x1/0x1 lookup eth1
      # nft add table filter
      # nft add chain filter output {type route hook output priority 0 \;}
      # nft add rule filter output mark set 0x1
      # nft add rule filter output queue num 0
    
    But after we reinject the skbuff, the packet will be sent via the
    wrong route, i.e. in this case, the packet will be routed via eth0
    table, not eth1 table. Because we skip to do re-route when verdict
    is NF_QUEUE, even if the mark was changed.
    
    Acctually, we should not touch sk_buff if verdict is NF_DROP or
    NF_STOLEN, and when re-route fails, return NF_DROP with error code.
    This is consistent with the mangle table in iptables.
    Signed-off-by: default avatarLiping Zhang <liping.zhang@spreadtrum.com>
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    d1a6cba5
nft_chain_route_ipv4.c 2.18 KB