• Bartosz Golaszewski's avatar
    usb: ohci-da8xx: disable the regulator if the overcurrent irq fired · d3273301
    Bartosz Golaszewski authored
    Historically the power supply management in this driver has been handled
    in two separate places in parallel. Device-tree users simply defined an
    appropriate regulator, while two boards with no DT support (da830-evm and
    omapl138-hawk) passed functions defined in their respective board files
    over platform data. These functions simply used legacy GPIO calls to
    watch the oc GPIO for interrupts and disable the vbus GPIO when the irq
    fires.
    
    Commit d193abf1 ("usb: ohci-da8xx: add vbus and overcurrent gpios")
    updated these GPIO calls to the modern API and moved them inside the
    driver.
    
    This however is not the optimal solution for the vbus GPIO which should
    be modeled as a fixed regulator that can be controlled with a GPIO.
    
    In order to keep the overcurrent protection available once we move the
    board files to using fixed regulators we need to disable the enable_reg
    regulator when the overcurrent indicator interrupt fires. Since we
    cannot call regulator_disable() from interrupt context, we need to
    switch to using a oneshot threaded interrupt.
    Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
    Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: default avatarSekhar Nori <nsekhar@ti.com>
    d3273301
ohci-da8xx.c 13.6 KB