• Dan Williams's avatar
    libnvdimm, pfn: fix memmap reservation sizing · d43a71c7
    Dan Williams authored
    commit 658922e5 upstream.
    
    When configuring a pfn-device instance to allocate the memmap array it
    needs to account for the fact that vmemmap_populate_hugepages()
    allocates struct page blocks in HPAGE_SIZE chunks.  We need to align the
    reserved area size to 2MB otherwise arch_add_memory() runs out of memory
    while establishing the memmap:
    
     WARNING: CPU: 0 PID: 496 at arch/x86/mm/init_64.c:704 arch_add_memory+0xe7/0xf0
     [..]
     Call Trace:
      [<ffffffff8148bdb3>] dump_stack+0x85/0xc2
      [<ffffffff810a749b>] __warn+0xcb/0xf0
      [<ffffffff810a75cd>] warn_slowpath_null+0x1d/0x20
      [<ffffffff8106a497>] arch_add_memory+0xe7/0xf0
      [<ffffffff811d2097>] devm_memremap_pages+0x287/0x450
      [<ffffffff811d1ffa>] ? devm_memremap_pages+0x1ea/0x450
      [<ffffffffa0000298>] __wrap_devm_memremap_pages+0x58/0x70 [nfit_test_iomap]
      [<ffffffffa0047a58>] pmem_attach_disk+0x318/0x420 [nd_pmem]
      [<ffffffffa0047bcf>] nd_pmem_probe+0x6f/0x90 [nd_pmem]
      [<ffffffffa0009469>] nvdimm_bus_probe+0x69/0x110 [libnvdimm]
     [..]
      ndbus0: nd_pmem.probe(pfn3.0) = -12
     nd_pmem: probe of pfn3.0 failed with error -12
    libndctl: ndctl_pfn_enable: pfn3.0: failed to enable
    Reported-by: default avatarNamratha Kothapalli <namratha.n.kothapalli@intel.com>
    Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    
    d43a71c7
pmem.c 13.4 KB