• Jinjie Ruan's avatar
    clk: samsung: Fix out-of-bound access of of_match_node() · a03c246d
    Jinjie Ruan authored
    Currently, there is no terminator entry for exynosautov920_cmu_of_match,
    hence facing below KASAN warning,
    
    	BUG: KASAN: global-out-of-bounds in of_match_node+0x120/0x13c
    	Read of size 1 at addr ffffffe31cc9e628 by task swapper/0/1
    
    	CPU: 1 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.11.0+ #334
    	Hardware name: linux,dummy-virt (DT)
    	Call trace:
    	 dump_backtrace+0x94/0xec
    	 show_stack+0x18/0x24
    	 dump_stack_lvl+0x90/0xd0
    	 print_report+0x1f4/0x5b4
    	 kasan_report+0xc8/0x110
    	 __asan_report_load1_noabort+0x20/0x2c
    	 of_match_node+0x120/0x13c
    	 of_match_device+0x70/0xb4
    	 platform_match+0xa0/0x25c
    	 __device_attach_driver+0x7c/0x2d4
    	 bus_for_each_drv+0x100/0x188
    	 __device_attach+0x174/0x364
    	 device_initial_probe+0x14/0x20
    	 bus_probe_device+0x128/0x158
    	 device_add+0xb3c/0x10fc
    	 of_device_add+0xdc/0x150
    	 of_platform_device_create_pdata+0x120/0x20c
    	 of_platform_bus_create+0x2bc/0x620
    	 of_platform_populate+0x58/0x108
    	 of_platform_default_populate_init+0x100/0x120
    	 do_one_initcall+0x110/0x788
    	 kernel_init_freeable+0x44c/0x61c
    	 kernel_init+0x24/0x1e4
    	 ret_from_fork+0x10/0x20
    
    	The buggy address belongs to the variable:
    	 exynosautov920_cmu_of_match+0xc8/0x2c80
    
    Add a dummy terminator entry at the end to assist of_match_node() in
    traversing up to the terminator entry without accessing an
    out-of-boundary index.
    
    Fixes: 485e13fe ("clk: samsung: add top clock support for ExynosAuto v920 SoC")
    Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
    Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
    Link: https://lore.kernel.org/r/20240927102104.3268790-1-ruanjinjie@huawei.com
    [krzk: drop trailing comma]
    Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    a03c246d
clk-exynosautov920.c 45.4 KB