• Yang Shi's avatar
    block: introduce block_rq_error tracepoint · d5869fdc
    Yang Shi authored
    Currently, rasdaemon uses the existing tracepoint block_rq_complete
    and filters out non-error cases in order to capture block disk errors.
    
    But there are a few problems with this approach:
    
    1. Even kernel trace filter could do the filtering work, there is
       still some overhead after we enable this tracepoint.
    
    2. The filter is merely based on errno, which does not align with kernel
       logic to check the errors for print_req_error().
    
    3. block_rq_complete only provides dev major and minor to identify
       the block device, it is not convenient to use in user-space.
    
    So introduce a new tracepoint block_rq_error just for the error case.
    With this patch, rasdaemon could switch to block_rq_error.
    
    Since the new tracepoint has the similar implementation with
    block_rq_complete, so move the existing code from TRACE_EVENT
    block_rq_complete() into new event class block_rq_completion(). Then add
    event for block_rq_complete and block_rq_err respectively from the newly
    created event class per the suggestion from Chaitanya Kulkarni.
    
    Cc: Jens Axboe <axboe@kernel.dk>
    Cc: Christoph Hellwig <hch@infradead.org>
    Reviewed-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
    Signed-off-by: default avatarYang Shi <shy828301@gmail.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Link: https://lore.kernel.org/r/20220210225222.260069-1-shy828301@gmail.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    d5869fdc
block.h 14.3 KB