• Alexander Duyck's avatar
    opa_vnic: Just use skb_get_hash instead of skb_tx_hash · d80d8d55
    Alexander Duyck authored
    This patch is meant to clean up how the opa_vnic is obtaining entropy from
    Tx packets.
    
    The code as it was written was claiming to get 16 bits of hash, but from
    what I can tell it was only ever actually getting 14 bits as it was limited
    to 0 - (2^15 - 1). It then was folding the result to get a 8 bit value for
    entropy.
    
    Instead of throwing away all that input I am cutting out the middle man and
    instead having the code call skb_get_hash directly and then folding the 32
    bit value into a 8 bit value using a pair of shifts and XOR operations.
    
    Execution wise this new approach should provide more entropy and be faster
    since we are bypassing the reciprocal multiplication to reduce the 32b
    value to 16b and instead just using a shift/XOR combination.
    
    In addition we can drop the unneeded adapter value from the call to get the
    entropy since the netdev itself isn't even needed.
    Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d80d8d55
opa_vnic_encap.c 14.7 KB