• Kenn Humborg's avatar
    [PATCH] NCR5380 delayed work fix and locking fix · 5a550acd
    Kenn Humborg authored
    Changes to the NCR5380 driver between 2.6.9 and 2.6.10 replaced the
    driver's home-grown delayed work implementation with a call to
    schedule_delayed_work().  However, the delay argument was not passed
    correctly, so the work was usually scheduled for _way_ too far in
    the future.  This patch fixes this.
    
    NCR5380_print_status() is called from NCR5380_abort() and from
    NCR5380_bus_reset().  In at least the abort() case, the host lock
    has already been acquired by scsi_error.c:scsi_try_to_abort_command().
    NCR5380_print_status() calls NCR5380_proc_info() which also acquires
    and releases the host lock.  This patch removes the call to
    NCR5380_proc_info() from NCR5380_print_status.
    
    Cosmetic: Remove duplicated lines of code from NCR5380_abort().
    Signed-off-by: default avatarKenn Humborg <kenn@linux.ie>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
    5a550acd
NCR5380.c 91.8 KB