• Geert Uytterhoeven's avatar
    m68k: Fix virt_addr_valid() W=1 compiler warnings · a65a802a
    Geert Uytterhoeven authored
    If CONFIG_DEBUG_SG=y, and CONFIG_MMU=y:
    
        include/linux/scatterlist.h: In function ‘sg_set_buf’:
        arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
          174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
    	  |                                                 ^~
    
    or CONFIG_MMU=n:
    
        include/linux/scatterlist.h: In function ‘sg_set_buf’:
        arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
           33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
    	  |                                                  ^~
    
    Fix this by doing the comparison in the "unsigned long" instead of the
    "void *" domain.
    
    Note that for now this is only seen when compiling btrfs, due to commit
    e9aa7c28 ("btrfs: enable W=1 checks for btrfs"), but as people
    are doing more W=1 compile testing, it will start to show up elsewhere,
    too.
    Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Acked-by: default avatarGreg Ungerer <gerg@linux-m68k.org>
    Link: https://lore.kernel.org/r/20210305084122.4118826-1-geert@linux-m68k.org
    a65a802a
page_no.h 1.3 KB