• Peter Zijlstra's avatar
    objtool: Support pv_opsindirect calls for noinstr · db2b0c5d
    Peter Zijlstra authored
    Normally objtool will now follow indirect calls; there is no need.
    
    However, this becomes a problem with noinstr validation; if there's an
    indirect call from noinstr code, we very much need to know it is to
    another noinstr function. Luckily there aren't many indirect calls in
    entry code with the obvious exception of paravirt. As such, noinstr
    validation didn't work with paravirt kernels.
    
    In order to track pv_ops[] call targets, objtool reads the static
    pv_ops[] tables as well as direct assignments to the pv_ops[] array,
    provided the compiler makes them a single instruction like:
    
      bf87:       48 c7 05 00 00 00 00 00 00 00 00        movq   $0x0,0x0(%rip)
        bf92 <xen_init_spinlocks+0x5f>
        bf8a: R_X86_64_PC32     pv_ops+0x268
    
    There are, as of yet, no warnings for when this goes wrong :/
    
    Using the functions found with the above means, all pv_ops[] calls are
    now subject to noinstr validation.
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20210624095149.118815755@infradead.org
    db2b0c5d
objtool.c 4.61 KB