• Gabriel Paubert's avatar
    [PATCH] I2C: Recent I2C "dead code removal" breaks pmac sound. · 95e475c9
    Gabriel Paubert authored
    > Put the function back, and change the pmac.h file to delete the #define,
    > and replace the snd_pmac_keywest_write function with a real call to
    > i2c_smbus_write_block_data so things like this don't happen again.
    >
    > Care to write a patch to do this?
    
    It follows, along with an update of the include/linux/i2c.h to only
    declare functions that actually exist, but grepping the whole sound
    subtree shows that at least sound/oss/dmasound/tas_common.h defines
    a few inline functions that call i2c_smbus_write_{byte,block}_data.
    
    
    [I2C part]
    Ressuscitate i2c_smbus_write_block_data since it's actually
    used. Update include/linux/i2c.h to reflect the existing
    functions.
    
    [Sound part]
    Remove snd_pmac_keywest_write* wrapper macros and directly
    call the i2c_smbus_* functions instead.
    Signed-off-by: default avatarGabriel Paubert <paubert@iram.es>
    Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
    
    
    ===== include/linux/i2c.h 1.41 vs edited =====
    95e475c9
daca.c 6.89 KB