• Tony Lindgren's avatar
    clk: ti: clkctrl: Fix clkdm_name regression for TI_CLK_CLKCTRL_COMPAT · d17a718d
    Tony Lindgren authored
    Commit a72d7850 ("clk: ti: Prepare for remove of OF node name")
    changed the code to use kasprintf() for provider->clkdm_name but also
    changed the offset used later on by three. We don't need to change the
    offset as we already have the extra three characters in the format for
    kasprintf with "%pOFnxxx".
    
    This caused the clocks with TI_CLK_CLKCTRL_COMPAT to have NULL
    clk->clkdm_name for omap4 and 5. And null clkdm_name can cause module
    reset, enable, and idle to fail.
    
    The issue can also be seen also when enabling DEBUG for clkctrl.c
    and then we start seeing "clock: could not associate" messages for
    omap4 and 5 as the generated name is something like "l4_wkclkdm" instead
    of "l4_wkup_clkdm" that's needed.
    
    Let's fix the issue with a partial revert of commit a72d7850 ("clk:
    ti: Prepare for remove of OF node name").
    
    ALso note that in general code should not depend on the dts node names.
    And the node names should be generic types like clock-domain in this case.
    This could be fixed later by using separate compatible properties for the
    clockdomains, or by adding soc_device_match() table with reg offsets
    to the driver. But let's fix the regression first.
    
    Fixes: a72d7850 ("clk: ti: Prepare for remove of OF node name")
    Cc: Tero Kristo <t-kristo@ti.com>
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
    d17a718d
clkctrl.c 14.5 KB