• Guillaume Nault's avatar
    ipv4: Reject again rules with high DSCP values · dc513a40
    Guillaume Nault authored
    Commit 563f8e97 ("ipv4: Stop taking ECN bits into account in
    fib4-rules") replaced the validation test on frh->tos. While the new
    test is stricter for ECN bits, it doesn't detect the use of high order
    DSCP bits. This would be fine if IPv4 could properly handle them. But
    currently, most IPv4 lookups are done with the three high DSCP bits
    masked. Therefore, using these bits doesn't lead to the expected
    result.
    
    Let's reject such configurations again, so that nobody starts to
    use and make any assumption about how the stack handles the three high
    order DSCP bits in fib4 rules.
    
    Fixes: 563f8e97 ("ipv4: Stop taking ECN bits into account in fib4-rules")
    Signed-off-by: default avatarGuillaume Nault <gnault@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    dc513a40
fib_rules.c 9.99 KB