• Daniel Walker's avatar
    [PATCH] idetape gcc 4.1 warning fix · dcd96379
    Daniel Walker authored
    In both the read and write cases it will return an error if
    copy_{from/to}_user faults.  However, I let the driver try to read/write as
    much as it can just as it normally would , then finally it returns an error
    if there was one.  This was the most straight forward way to handle the
    error , since there isn't a clear way to clean up the buffers on error .
    
    I moved retval in idetape_chrdev_write() down into the actual code blocks
    since it's really once used there, and it conflicted with my ret variable.
    
    Fixes the following warning,
    
    drivers/ide/ide-tape.c: In function ‘idetape_copy_stage_from_user’:
    drivers/ide/ide-tape.c:2662: warning: ignoring return value of ‘copy_from_user’, declared with attribute warn_unused_result
    drivers/ide/ide-tape.c: In function ‘idetape_copy_stage_to_user’:
    drivers/ide/ide-tape.c:2689: warning: ignoring return value of ‘copy_to_user’, declared with attribute warn_unused_result
    Signed-off-by: default avatarDaniel Walker <dwalker@mvista.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    dcd96379
ide-tape.c 163 KB