• Guenter Roeck's avatar
    watchdog: digicolor_wdt: Convert to use device managed functions and other improvements · dd36f6ce
    Guenter Roeck authored
    Use device managed functions to simplify error handling, reduce
    source code size, improve readability, and reduce the likelyhood of bugs.
    Other improvements as listed below.
    
    The conversion was done automatically with coccinelle using the
    following semantic patches. The semantic patches and the scripts used
    to generate this commit log are available at
    https://github.com/groeck/coccinelle-patches
    
    - Replace 'goto l; ... l: return e;' with 'return e;'
    - Replace 'val = e; return val;' with 'return e;'
    - Drop assignments to otherwise unused variables
    - Replace 'if (e) { return expr; }' with 'if (e) return expr;'
    - Drop remove function
    - Replace of_iomap() with platform_get_resource() followed by
      devm_ioremap_resource()
    - Drop platform_set_drvdata()
    - Replace &pdev->dev with dev if 'struct device *dev' is a declared
      variable
    - Use devm_watchdog_register_driver() to register watchdog device
    - Replace shutdown function with call to watchdog_stop_on_reboot()
    Acked-by: default avatarBaruch Siach <baruch@tkos.co.il>
    Tested-by: default avatarBaruch Siach <baruch@tkos.co.il>
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    dd36f6ce
digicolor_wdt.c 4.16 KB