• Dan Streetman's avatar
    nbd: ratelimit error msgs after socket close · dd37eba1
    Dan Streetman authored
    commit da6ccaaa upstream.
    
    Make the "Attempted send on closed socket" error messages generated in
    nbd_request_handler() ratelimited.
    
    When the nbd socket is shutdown, the nbd_request_handler() function emits
    an error message for every request remaining in its queue.  If the queue
    is large, this will spam a large amount of messages to the log.  There's
    no need for a separate error message for each request, so this patch
    ratelimits it.
    
    In the specific case this was found, the system was virtual and the error
    messages were logged to the serial port, which overwhelmed it.
    
    Fixes: 4d48a542 ("nbd: fix I/O hang on disconnected nbds")
    Signed-off-by: default avatarDan Streetman <dan.streetman@canonical.com>
    Signed-off-by: default avatarMarkus Pargmann <mpa@pengutronix.de>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    dd37eba1
nbd.c 22.3 KB