• Peter Zijlstra's avatar
    sched: Fix crash trying to dequeue/enqueue the idle thread · de9b8f5d
    Peter Zijlstra authored
    Sasha reports that his virtual machine tries to schedule the idle
    thread since commit 6c37067e ("sched: Change the
    sched_class::set_cpus_allowed() calling context").
    
    Hit trace shows this happening from idle_thread_get()->init_idle(),
    which is the _second_ init_idle() invocation on that task_struct, the
    first being done through idle_init()->fork_idle(). (this code is
    insane...)
    
    Because we call init_idle() twice in a row, its ->sched_class ==
    &idle_sched_class and ->on_rq = TASK_ON_RQ_QUEUED. This means
    do_set_cpus_allowed() think we're queued and will call dequeue_task(),
    which is implemented with BUG() for the idle class, seeing how
    dequeueing the idle task is a daft thing.
    
    Aside of the whole insanity of calling init_idle() _twice_, change the
    code to call set_cpus_allowed_common() instead as this is 'obviously'
    before the idle task gets ran etc..
    Reported-by: default avatarSasha Levin <sasha.levin@oracle.com>
    Tested-by: default avatarSasha Levin <sasha.levin@oracle.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Fixes: 6c37067e ("sched: Change the sched_class::set_cpus_allowed() calling context")
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    de9b8f5d
core.c 205 KB