• Arnaldo Carvalho de Melo's avatar
    perf probe: Set pev->nargs to zero after freeing pev->args entries · df8350ed
    Arnaldo Carvalho de Melo authored
    So that, when perf_add_probe_events() fails, like in:
    
      # perf probe icmp_rcv:64 "type=icmph->type"
      Failed to find 'icmph' in this function.
        Error: Failed to add events.
      Segmentation fault (core dumped)
      #
    
    We don't segfault.
    
    clear_perf_probe_event() was zeroing the whole pev, and since the switch
    to zfree() for the members in the pev, that memset() was removed, which
    left nargs with its original value, in the above case 1.
    
    With the memset the same pev could be passed to clear_perf_probe_event()
    multiple times, since all it would have would be zeroes, and free()
    accepts zero, the loop would not happen and we would just memset it
    again to zeroes.
    
    Without it we got that segfault, so zero nargs to keep it like it was,
    next cset will avoid calling clear_perf_probe_event() for the same pevs
    in case of failure.
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Fixes: d8f9da24 ("perf tools: Use zfree() where applicable")
    Link: https://lkml.kernel.org/n/tip-802f2jypnwqsvyavvivs8464@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    df8350ed
probe-event.c 80.6 KB