• Arnaldo Carvalho de Melo's avatar
    Revert "perf sched: Handle PERF_RECORD_EXIT events" · 1c6763cb
    Arnaldo Carvalho de Melo authored
    This reverts commit 0439539f.
    
    This caused this segfault:
    
    [root@sandy linux]# perf sched rec
    ^C[ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 1.306 MB perf.data (~57062 samples) ]
    perf
    [root@sandy linux]# perf sched lat
    perf: builtin-sched.c:781: thread_atoms_search: Assertion `!(thread != atoms->thread)' failed.
    Aborted (core dumped)
    [root@sandy linux]#
    
    Further investigation is needed to check that even with machine__remove_thread()
    not really deleting the thread referenced in the PERF_RECORD_EXIT (it goes to
    machine->dead_threads, because references may still exist to them in things like
     hist, etc) some event later comes for this dead thread and then
    machine__findnew_thread() will create a new thead instance that will not be the
    same as the one referenced by work_atoms->thread in thread_atoms_search().
    
    For now just revert this patch to get the 'perf sched lat' back working.
    
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    echo Link: http://lkml.kernel.org/n/tip-`ranpwd -l 24`@git.kernel.org
    Link: http://lkml.kernel.org/n/tip-hg4s6e5txiwqe00h8rdg1sin@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    1c6763cb
builtin-sched.c 44.4 KB