• NeilBrown's avatar
    NFSD: correctly range-check v4.x minor version when setting versions. · e35659f1
    NeilBrown authored
    Writing to /proc/fs/nfsd/versions allows individual major versions
    and NFSv4 minor versions to be enabled or disabled.
    
    However NFSv4.0 cannot currently be disabled, thought there is no good reason.
    Also the minor number is parsed as a 'long' but used as an 'int'
    so '4294967297' will be incorrectly treated as '1'.
    
    This patch removes the test on 'minor == 0' and switches to kstrtouint()
    to get correct range checking.
    
    When reading from /proc/fs/nfsd/versions, 4.0 is current not reported.
    To allow the disabling for v4.0 to be visible, while maintaining
    backward compatibility, change code to report "-4.0" if appropriate, but
    not "+4.0".
    Signed-off-by: default avatarNeilBrown <neilb@suse.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    e35659f1
nfsctl.c 33 KB