• Johan Hovold's avatar
    serial: stm32: fix threaded interrupt handling · e359b441
    Johan Hovold authored
    When DMA is enabled the receive handler runs in a threaded handler, but
    the primary handler up until very recently neither disabled interrupts
    in the device or used IRQF_ONESHOT. This would lead to a deadlock if an
    interrupt comes in while the threaded receive handler is running under
    the port lock.
    
    Commit ad767681 ("serial: stm32: fix a deadlock condition with
    wakeup event") claimed to fix an unrelated deadlock, but unfortunately
    also disabled interrupts in the threaded handler. While this prevents
    the deadlock mentioned in the previous paragraph it also defeats the
    purpose of using a threaded handler in the first place.
    
    Fix this by making the interrupt one-shot and not disabling interrupts
    in the threaded handler.
    
    Note that (receive) DMA must not be used for a console port as the
    threaded handler could be interrupted while holding the port lock,
    something which could lead to a deadlock in case an interrupt handler
    ends up calling printk.
    
    Fixes: ad767681 ("serial: stm32: fix a deadlock condition with wakeup event")
    Fixes: 34891872 ("serial: stm32: adding dma support")
    Cc: stable@vger.kernel.org      # 4.9
    Cc: Alexandre TORGUE <alexandre.torgue@st.com>
    Cc: Gerald Baeza <gerald.baeza@st.com>
    Reviewed-by: Valentin Caron<valentin.caron@foss.st.com>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20210416140557.25177-3-johan@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    e359b441
stm32-usart.c 43 KB