• Geert Uytterhoeven's avatar
    serial: sh-sci: Fix hang in sci_reset() · e37f712f
    Geert Uytterhoeven authored
    When the .set_termios() callback resets the UART, it first waits (busy
    loops) until all characters in the transmit FIFO have been transmitted,
    to prevent a port configuration change from impacting these characters.
    
    However, if the UART has dedicated RTS/CTS hardware flow control
    enabled, these characters may have been stuck in the FIFO due to CTS not
    being asserted by the remote side.
    
      - When a new user opens the port, .set_termios() is called while
        transmission is still disabled, leading to an infinite loop:
    
    	NMI watchdog: BUG: soft lockup - CPU#0 stuck for 22s!
    
      - When an active user changes port configuration without waiting for
        the draining of the transmit FIFO, this may also block indefinitely,
        until CTS is asserted by the remote side.
    
    This has been observed with SCIFA (on r8a7740/armadillo), and SCIFB and
    HSCIF (on r8a7791/koelsch).
    
    To fix this, remove the code that waits for the draining of the transmit
    FIFO.
    Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    e37f712f
sh-sci.c 78.5 KB