• Thomas Gleixner's avatar
    PCI/MSI: Remove over-zealous hardware size check in pci_msix_validate_entries() · e3c026be
    Thomas Gleixner authored
    pci_msix_validate_entries() validates the entries array which is handed in
    by the caller for a MSI-X interrupt allocation. Aside of consistency
    failures it also detects a failure when the size of the MSI-X hardware table
    in the device is smaller than the size of the entries array.
    
    That's wrong for the case of range allocations where the caller provides
    the minimum and the maximum number of vectors to allocate, when the
    hardware size is greater or equal than the mininum, but smaller than the
    maximum.
    
    Remove the hardware size check completely from that function and just
    ensure that the entires array up to the maximum size is consistent.
    
    The limitation and range checking versus the hardware size happens
    independently of that afterwards anyway because the entries array is
    optional.
    
    Fixes: 4644d22e ("PCI/MSI: Validate MSI-X contiguous restriction early")
    Reported-by: default avatarDavid Laight <David.Laight@aculab.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/87v8i3sg62.ffs@tglx
    e3c026be
msi.c 23 KB