• Willy Tarreau's avatar
    l2tp: fix another panic in pppol2tp · e3dea307
    Willy Tarreau authored
    Commit 3feec909 ("l2tp: Fix oops in pppol2tp_xmit") was backported
    into 2.6.32.16 to fix a possible null deref in pppol2tp. But the same
    still exists in pppol2tp_sendmsg() possibly causing the same crash.
    Note that this bug doesn't appear to have any other impact than crashing
    the system, as the dereferenced pointer is only used to test a value
    against a 3-bit mask, so it can hardly be abused for anything except
    leaking one third of a bit of memory.
    
    This issue doesn't exist upstream because the code was replaced in 2.6.35
    and the new function l2tp_xmit_skb() performs the appropriate check.
    Reported-by: default avatarBen Hutchings <ben@decadent.org.uk>
    Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
    e3dea307
pppol2tp.c 69.7 KB