• Corrado Zoccolo's avatar
    cfq-iosched: fix ncq detection code · e459dd08
    Corrado Zoccolo authored
    CFQ's detection of queueing devices initially assumes a queuing device
    and detects if the queue depth reaches a certain threshold.
    However, it will reconsider this choice periodically.
    
    Unfortunately, if device is considered not queuing, CFQ will force a
    unit queue depth for some workloads, thus defeating the detection logic.
    This leads to poor performance on queuing hardware,
    since the idle window remains enabled.
    
    Given this premise, switching to hw_tag = 0 after we have proved at
    least once that the device is NCQ capable is not a good choice.
    
    The new detection code starts in an indeterminate state, in which CFQ behaves
    as if hw_tag = 1, and then, if for a long observation period we never saw
    large depth, we switch to hw_tag = 0, otherwise we stick to hw_tag = 1,
    without reconsidering it again.
    Signed-off-by: default avatarCorrado Zoccolo <czoccolo@gmail.com>
    Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
    e459dd08
cfq-iosched.c 76.4 KB