• Jani Nikula's avatar
    drm/edid: add struct drm_edid container · e4ccf9a7
    Jani Nikula authored
    Introduce new opaque type struct drm_edid to encapsulate the EDID data
    and the size allocated for it. The contents will be private to
    drm_edid.c.
    
    There are a number of reasons for adding a container around struct edid:
    
    * struct edid is a raw blob pointer to data that usually originates
      outside of the kernel. Its size is contained within the structure.
    
    * There's no way to attach meta information (such as allocated memory
      size) to struct edid.
    
    * Validation of the EDID blob and its size become crucial, and it's
      spread all over the subsystem, with varying levels of accuracy.
    
    * HDMI Forum has introduced an HF-EEODB extension that defines an
      override EDID size within an EDID extension. The size allocated for an
      EDID depends on whether the allocator understands the HF-EEODB
      extension. Given a struct edid *, it's impossible to know how much
      memory was actually allocated for it.
    
    There are also some reasons for making the container type struct
    drm_edid opaque and private to drm_edid.c:
    
    * Have only one place for creating and parsing the EDID, to avoid
      duplicating bugs.
    
    * Prepare for reading a pure DisplayID 2.0 from its own DDC address, and
      adding it within the same struct drm_edid container, transparently,
      and for all drivers.
    
    * With the idea that the drm_edid objects are immutable during their
      lifetimes, it will be possible to refcount them and reduce EDID
      copying everywhere (this is left for future work).
    
    Initially, just add the type. In follow-up, we'll start converting the
    guts of drm_edid.c to use it, and finally add interfaces around it.
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Reviewed-by: default avatarAnkit Nautiyal <ankit.k.nautiyal@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/f3ecabd8a219aea678ad00f7bcdecf77b27b3c78.1652097712.git.jani.nikula@intel.com
    e4ccf9a7
drm_edid.c 194 KB