• Christophe JAILLET's avatar
    ipw2x00: switch from 'pci_' to 'dma_' API · e52525c0
    Christophe JAILLET authored
    The wrappers in include/linux/pci-dma-compat.h should go away.
    
    The patch has been generated with the coccinelle script below and has been
    hand modified to replace GFP_ with a correct flag.
    It has been compile tested.
    
    When memory is allocated in 'ipw2100_msg_allocate()' (ipw2100.c),
    GFP_KERNEL can be used because it is called from the probe function.
    The call chain is:
       ipw2100_pci_init_one            (the probe function)
         --> ipw2100_queues_allocate
           --> ipw2100_msg_allocate
    Moreover, 'ipw2100_msg_allocate()' already uses GFP_KERNEL for some other
    memory allocations.
    
    When memory is allocated in 'status_queue_allocate()' (ipw2100.c),
    GFP_KERNEL can be used because it is called from the probe function.
    The call chain is:
       ipw2100_pci_init_one            (the probe function)
         --> ipw2100_queues_allocate
           --> ipw2100_rx_allocate
             --> status_queue_allocate
    Moreover, 'ipw2100_rx_allocate()' already uses GFP_KERNEL for some other
    memory allocations.
    
    When memory is allocated in 'bd_queue_allocate()' (ipw2100.c),
    GFP_KERNEL can be used because it is called from the probe function.
    The call chain is:
       ipw2100_pci_init_one            (the probe function)
         --> ipw2100_queues_allocate
           --> ipw2100_rx_allocate
             --> bd_queue_allocate
    Moreover, 'ipw2100_rx_allocate()' already uses GFP_KERNEL for some other
    memory allocations.
    
    When memory is allocated in 'ipw2100_tx_allocate()' (ipw2100.c),
    GFP_KERNEL can be used because it is called from the probe function.
    The call chain is:
       ipw2100_pci_init_one            (the probe function)
         --> ipw2100_queues_allocate
           --> ipw2100_tx_allocate
    Moreover, 'ipw2100_tx_allocate()' already uses GFP_KERNEL for some other
    memory allocations.
    
    When memory is allocated in 'ipw_queue_tx_init()' (ipw2200.c),
    GFP_KERNEL can be used because it is called from a call chain that already
    uses GFP_KERNEL and no spin_lock is taken in the between.
    The call chain is:
       ipw_up
         --> ipw_load
           --> ipw_queue_reset
             --> ipw_queue_tx_init
    'ipw_up()' already uses GFP_KERNEL for some other memory allocations.
    
    @@
    @@
    -    PCI_DMA_BIDIRECTIONAL
    +    DMA_BIDIRECTIONAL
    
    @@
    @@
    -    PCI_DMA_TODEVICE
    +    DMA_TO_DEVICE
    
    @@
    @@
    -    PCI_DMA_FROMDEVICE
    +    DMA_FROM_DEVICE
    
    @@
    @@
    -    PCI_DMA_NONE
    +    DMA_NONE
    
    @@
    expression e1, e2, e3;
    @@
    -    pci_alloc_consistent(e1, e2, e3)
    +    dma_alloc_coherent(&e1->dev, e2, e3, GFP_)
    
    @@
    expression e1, e2, e3;
    @@
    -    pci_zalloc_consistent(e1, e2, e3)
    +    dma_alloc_coherent(&e1->dev, e2, e3, GFP_)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_free_consistent(e1, e2, e3, e4)
    +    dma_free_coherent(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_map_single(e1, e2, e3, e4)
    +    dma_map_single(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_unmap_single(e1, e2, e3, e4)
    +    dma_unmap_single(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4, e5;
    @@
    -    pci_map_page(e1, e2, e3, e4, e5)
    +    dma_map_page(&e1->dev, e2, e3, e4, e5)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_unmap_page(e1, e2, e3, e4)
    +    dma_unmap_page(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_map_sg(e1, e2, e3, e4)
    +    dma_map_sg(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_unmap_sg(e1, e2, e3, e4)
    +    dma_unmap_sg(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_dma_sync_single_for_cpu(e1, e2, e3, e4)
    +    dma_sync_single_for_cpu(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_dma_sync_single_for_device(e1, e2, e3, e4)
    +    dma_sync_single_for_device(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_dma_sync_sg_for_cpu(e1, e2, e3, e4)
    +    dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2, e3, e4;
    @@
    -    pci_dma_sync_sg_for_device(e1, e2, e3, e4)
    +    dma_sync_sg_for_device(&e1->dev, e2, e3, e4)
    
    @@
    expression e1, e2;
    @@
    -    pci_dma_mapping_error(e1, e2)
    +    dma_mapping_error(&e1->dev, e2)
    
    @@
    expression e1, e2;
    @@
    -    pci_set_dma_mask(e1, e2)
    +    dma_set_mask(&e1->dev, e2)
    
    @@
    expression e1, e2;
    @@
    -    pci_set_consistent_dma_mask(e1, e2)
    +    dma_set_coherent_mask(&e1->dev, e2)
    Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20200722101716.26185-1-christophe.jaillet@wanadoo.fr
    e52525c0
ipw2200.c 323 KB