• Stephen Boyd's avatar
    clk: qcom: msm8960: Fix dsi1/2 halt bits · e5bf1991
    Stephen Boyd authored
    The halt bits for these clocks seem wrong. I get the following
    warning while booting on an msm8960-cdp:
    
    WARNING: CPU: 0 PID: 1 at drivers/clk/qcom/clk-branch.c:97 clk_branch_toggle+0xd0/0x138()
    dsi1_clk status stuck at 'on'
    Modules linked in:
    CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.3.0-rc3-00113-g5532cfb5 #110
    Hardware name: Qualcomm (Flattened Device Tree)
    [<c0216984>] (unwind_backtrace) from [<c02138f8>] (show_stack+0x10/0x14)
    [<c02138f8>] (show_stack) from [<c04a525c>] (dump_stack+0x70/0xbc)
    [<c04a525c>] (dump_stack) from [<c0223c70>] (warn_slowpath_common+0x78/0xb4)
    [<c0223c70>] (warn_slowpath_common) from [<c0223d40>] (warn_slowpath_fmt+0x30/0x40)
    [<c0223d40>] (warn_slowpath_fmt) from [<c05fc2dc>] (clk_branch_toggle+0xd0/0x138)
    [<c05fc2dc>] (clk_branch_toggle) from [<c05f3f3c>] (clk_disable_unused_subtree+0x98/0x1b0)
    [<c05f3f3c>] (clk_disable_unused_subtree) from [<c05f3ec4>] (clk_disable_unused_subtree+0x20/0x1b0)
    [<c05f3ec4>] (clk_disable_unused_subtree) from [<c05f5474>] (clk_disable_unused+0x58/0xd8)
    [<c05f5474>] (clk_disable_unused) from [<c0209710>] (do_one_initcall+0xac/0x1ec)
    [<c0209710>] (do_one_initcall) from [<c0991db4>] (kernel_init_freeable+0x11c/0x1e8)
    [<c0991db4>] (kernel_init_freeable) from [<c0727ae0>] (kernel_init+0x8/0xec)
    [<c0727ae0>] (kernel_init) from [<c0210238>] (ret_from_fork+0x14/0x3c)
    
    Fix the status bits and the errors go away.
    
    Fixes: 5532cfb5 ("clk: qcom: mmcc-8960: Add DSI related clocks")
    Acked-by: default avatarArchit Taneja <architt@codeaurora.org>
    Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
    e5bf1991
mmcc-msm8960.c 68.4 KB