• Yu Kuai's avatar
    md: factor out a helper to wake up md_thread directly · e5e9b9cb
    Yu Kuai authored
    md_wakeup_thread() can't wakeup md_thread->tsk if md_thread->run is
    still in progress, and in some cases md_thread->tsk need to be woke up
    directly, like md_set_readonly() and do_md_stop().
    
    Commit 9dfbdafd ("md: unlock mddev before reap sync_thread in
    action_store") introduce a new scenario where unregister sync_thread is
    not protected by 'reconfig_mutex', this can cause null-ptr-deference in
    theroy:
    
    t1: md_set_readonly		t2: action_store
    				md_unregister_thread
    				// 'reconfig_mutex' is not held
    // 'reconfig_mutex' is held by caller
    if (mddev->sync_thread)
    				 thread = *threadp
    				 *threadp = NULL
     wake_up_process(mddev->sync_thread->tsk)
     // null-ptr-deference
    
    Fix this problem by factoring out a helper to wake up md_thread directly,
    so that 'sync_thread' won't be accessed multiple times from the reader
    side. This helper also prepare to protect md_thread with rcu.
    
    Noted that later patches is going to fix that unregister sync_thread is
    not protected by 'reconfig_mutex' from action_store().
    Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
    Signed-off-by: default avatarSong Liu <song@kernel.org>
    Link: https://lore.kernel.org/r/20230523021017.3048783-2-yukuai1@huaweicloud.com
    e5e9b9cb
md.c 261 KB