• Gal Pressman's avatar
    net: Make RX-FCS and LRO mutually exclusive · e6c6a929
    Gal Pressman authored
    LRO and RX-FCS offloads cannot be enabled at the same time since it is
    not clear what should happen to the FCS of each coalesced packet.
    The FCS is not really part of the TCP payload, hence cannot be merged
    into one big packet. On the other hand, providing one big LRO packet
    with one FCS contradicts the RX-FCS feature goal.
    
    Use the fix features mechanism in order to prevent intersection of the
    features and drop LRO in case RX-FCS is requested.
    
    Enabling RX-FCS while LRO is enabled will result in:
    $ ethtool -K ens6 rx-fcs on
    Actual changes:
    large-receive-offload: off [requested on]
    rx-fcs: on
    Signed-off-by: default avatarGal Pressman <galp@mellanox.com>
    Reviewed-by: default avatarTariq Toukan <tariqt@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    e6c6a929
dev.c 225 KB