• Lu Baolu's avatar
    iommu/vt-d: Fix incorrect cache invalidation for mm notification · e7ad6c2a
    Lu Baolu authored
    Commit 6bbd42e2 ("mmu_notifiers: call invalidate_range() when
    invalidating TLBs") moved the secondary TLB invalidations into the TLB
    invalidation functions to ensure that all secondary TLB invalidations
    happen at the same time as the CPU invalidation and added a flush-all
    type of secondary TLB invalidation for the batched mode, where a range
    of [0, -1UL) is used to indicates that the range extends to the end of
    the address space.
    
    However, using an end address of -1UL caused an overflow in the Intel
    IOMMU driver, where the end address was rounded up to the next page.
    As a result, both the IOTLB and device ATC were not invalidated correctly.
    
    Add a flush all helper function and call it when the invalidation range
    is from 0 to -1UL, ensuring that the entire caches are invalidated
    correctly.
    
    Fixes: 6bbd42e2 ("mmu_notifiers: call invalidate_range() when invalidating TLBs")
    Cc: stable@vger.kernel.org
    Cc: Huang Ying <ying.huang@intel.com>
    Cc: Alistair Popple <apopple@nvidia.com>
    Tested-by: Luo Yuzhang <yuzhang.luo@intel.com> # QAT
    Tested-by: Tony Zhu <tony.zhu@intel.com> # DSA
    Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
    Reviewed-by: default avatarAlistair Popple <apopple@nvidia.com>
    Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
    Link: https://lore.kernel.org/r/20231117090933.75267-1-baolu.lu@linux.intel.comSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
    e7ad6c2a
svm.c 21.5 KB