• Alex Chiang's avatar
    PCI: properly clean up ASPM link state on device remove · 3419c75e
    Alex Chiang authored
    We only want to disable ASPM when the last function is removed from
    the parent's device list. We determine this by checking to see if
    the parent's device list is completely empty.
    
    Unfortunately, we never hit that code because the parent is considered
    an upstream port, and never had an ASPM link_state associated with it.
    
    The early check for !link_state causes us to return early, we never
    discover that our device list is empty, and thus we never remove the
    downstream ports' link_state nodes.
    
    Instead of checking to see if the parent's device list is empty, we can
    check to see if we are the last device on the list, and if so, then we
    know that we can clean up properly.
    
    Cc: Shaohua Li <shaohua.li@intel.com>
    Signed-off-by: default avatarAlex Chiang <achiang@hp.com>
    Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    3419c75e
aspm.c 25.9 KB