• Julia Lawall's avatar
    scsi: fnic: Use vmalloc_array() and vcalloc() · b34c7dca
    Julia Lawall authored
    Use vmalloc_array() and vcalloc() to protect against multiplication
    overflows.
    
    The changes were done using the following Coccinelle semantic patch:
    
    // <smpl>
    @initialize:ocaml@
    @@
    
    let rename alloc =
      match alloc with
        "vmalloc" -> "vmalloc_array"
      | "vzalloc" -> "vcalloc"
      | _ -> failwith "unknown"
    
    @@
        size_t e1,e2;
        constant C1, C2;
        expression E1, E2, COUNT, x1, x2, x3;
        typedef u8;
        typedef __u8;
        type t = {u8,__u8,char,unsigned char};
        identifier alloc = {vmalloc,vzalloc};
        fresh identifier realloc = script:ocaml(alloc) { rename alloc };
    @@
    
    (
          alloc(x1*x2*x3)
    |
          alloc(C1 * C2)
    |
          alloc((sizeof(t)) * (COUNT), ...)
    |
    -     alloc((e1) * (e2))
    +     realloc(e1, e2)
    |
    -     alloc((e1) * (COUNT))
    +     realloc(COUNT, e1)
    |
    -     alloc((E1) * (E2))
    +     realloc(E1, E2)
    )
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
    Link: https://lore.kernel.org/r/20230627144339.144478-8-Julia.Lawall@inria.frSigned-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    b34c7dca
fnic_trace.c 27.8 KB