• Nathan Lynch's avatar
    powerpc/pseries: remove obsolete memory hotplug DT notifier code · e978a3cc
    Nathan Lynch authored
    pseries_update_drconf_memory() runs from a DT notifier in response to
    an update to the ibm,dynamic-memory property of the
    /ibm,dynamic-reconfiguration-memory node. This property is an older
    less compact format than the ibm,dynamic-memory-v2 property used in
    most currently supported firmwares. There has never been an equivalent
    function for the v2 property.
    
    pseries_update_drconf_memory() compares the 'assigned' flag for each
    LMB in the old vs new properties and adds or removes the block
    accordingly. However it appears to be of no actual utility:
    
    * Partition suspension and PRRNs are specified only to change LMBs'
      NUMA affinity information. This notifier should be a no-op for those
      scenarios since the assigned flags should not change.
    
    * The memory hotplug/DLPAR path has a hack which short-circuits
      execution of the notifier:
         dlpar_memory()
            ...
            rtas_hp_event = true;
            drmem_update_dt()
               of_update_property()
                  pseries_memory_notifier()
                     pseries_update_drconf_memory()
                        if (rtas_hp_event) return;
    
    So this code only makes sense as a relic of the time when more of the
    DLPAR workflow took place in user space. I don't see a purpose for it
    now.
    Signed-off-by: default avatarNathan Lynch <nathanl@linux.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20200612051238.1007764-19-nathanl@linux.ibm.com
    e978a3cc
hotplug-memory.c 19.7 KB