• Paolo Abeni's avatar
    net: sched: shrink struct Qdisc · e9be0e99
    Paolo Abeni authored
    The struct Qdisc has a lot of holes, especially after commit
    a53851e2 ("net: sched: explicit locking in gso_cpu fallback"),
    which as a side effect, moved the fields just after 'busylock'
    on a new cacheline.
    
    Since both 'padded' and 'refcnt' are not updated frequently, and
    there is a hole before 'gso_skb', we can move such fields there,
    saving a cacheline without any performance side effect.
    
    Before this commit:
    
    pahole -C Qdisc net/sche/sch_generic.o
    	# ...
            /* size: 384, cachelines: 6, members: 25 */
            /* sum members: 236, holes: 3, sum holes: 92 */
            /* padding: 56 */
    
    After this commit:
    pahole -C Qdisc net/sche/sch_generic.o
    	# ...
    	/* size: 320, cachelines: 5, members: 25 */
    	/* sum members: 236, holes: 2, sum holes: 28 */
    	/* padding: 56 */
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    e9be0e99
sch_generic.h 25.9 KB