• Nathan Chancellor's avatar
    scsi: isci: Use proper enumerated type in atapi_d2h_reg_frame_handler · e9e9a103
    Nathan Chancellor authored
    Clang warns when one enumerated type is implicitly converted to another.
    
    drivers/scsi/isci/request.c:1629:13: warning: implicit conversion from
    enumeration type 'enum sci_io_status' to different enumeration type
    'enum sci_status' [-Wenum-conversion]
                            status = SCI_IO_FAILURE_RESPONSE_VALID;
                                   ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/scsi/isci/request.c:1631:12: warning: implicit conversion from
    enumeration type 'enum sci_io_status' to different enumeration type
    'enum sci_status' [-Wenum-conversion]
                    status = SCI_IO_FAILURE_RESPONSE_VALID;
                           ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    status is of type sci_status but SCI_IO_FAILURE_RESPONSE_VALID is of
    type sci_io_status. Use SCI_FAILURE_IO_RESPONSE_VALID, which is from
    sci_status and has SCI_IO_FAILURE_RESPONSE_VALID's exact value since
    that is what SCI_IO_FAILURE_RESPONSE_VALID is mapped to in the isci.h
    file.
    
    Link: https://github.com/ClangBuiltLinux/linux/issues/153Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    e9e9a103
request.c 102 KB