• Josef Bacik's avatar
    btrfs: track reloc roots based on their commit root bytenr · ea287ab1
    Josef Bacik authored
    We always search the commit root of the extent tree for looking up back
    references, however we track the reloc roots based on their current
    bytenr.
    
    This is wrong, if we commit the transaction between relocating tree
    blocks we could end up in this code in build_backref_tree
    
      if (key.objectid == key.offset) {
    	  /*
    	   * Only root blocks of reloc trees use backref
    	   * pointing to itself.
    	   */
    	  root = find_reloc_root(rc, cur->bytenr);
    	  ASSERT(root);
    	  cur->root = root;
    	  break;
      }
    
    find_reloc_root() is looking based on the bytenr we had in the commit
    root, but if we've COWed this reloc root we will not find that bytenr,
    and we will trip over the ASSERT(root).
    
    Fix this by using the commit_root->start bytenr for indexing the commit
    root.  Then we change the __update_reloc_root() caller to be used when
    we switch the commit root for the reloc root during commit.
    
    This fixes the panic I was seeing when we started throttling relocation
    for delayed refs.
    Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    ea287ab1
relocation.c 116 KB