• Denys Vlasenko's avatar
    x86/asm/entry/32: Reinstate clearing of pt_regs->r8..r11 on EFAULT path · eb478544
    Denys Vlasenko authored
    I broke this recently when I changed pt_regs->r8..r11 clearing
    logic in INT 80 code path.
    
    There is a branch from SYSENTER/SYSCALL code to INT 80 code:
    if we fail to retrieve arg6, we return EFAULT. Before this
    patch, in this case we don't clear pt_regs->r8..r11.
    
    This patch fixes this. The resulting code is smaller and
    simpler.
    
    While at it, remove incorrect comment about syscall dispatching
    CALL insn: it does not use RIP-relative addressing form (the
    comment was meant to be "TODO: make this rip-relative", and
    morphed since then, dropping "TODO").
    Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
    Cc: Alexei Starovoitov <ast@plumgrid.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Will Drewry <wad@chromium.org>
    Link: http://lkml.kernel.org/r/1433701470-28800-1-git-send-email-dvlasenk@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    eb478544
entry_64_compat.S 15.3 KB