• Nicholas Piggin's avatar
    powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled · ebb37cf3
    Nicholas Piggin authored
    irq_work_raise should not cause a decrementer exception unless it is
    called from NMI context. Doing so often just results in an immediate
    masked decrementer interrupt:
    
       <...>-550    90d...    4us : update_curr_rt <-dequeue_task_rt
       <...>-550    90d...    5us : dbs_update_util_handler <-update_curr_rt
       <...>-550    90d...    6us : arch_irq_work_raise <-irq_work_queue
       <...>-550    90d...    7us : soft_nmi_interrupt <-soft_nmi_common
       <...>-550    90d...    7us : printk_nmi_enter <-soft_nmi_interrupt
       <...>-550    90d.Z.    8us : rcu_nmi_enter <-soft_nmi_interrupt
       <...>-550    90d.Z.    9us : rcu_nmi_exit <-soft_nmi_interrupt
       <...>-550    90d...    9us : printk_nmi_exit <-soft_nmi_interrupt
       <...>-550    90d...   10us : cpuacct_charge <-update_curr_rt
    
    The soft_nmi_interrupt here is the call into the watchdog, due to the
    decrementer interrupt firing with irqs soft-disabled. This is
    harmless, but sub-optimal.
    
    When it's not called from NMI context or with interrupts enabled, mark
    the decrementer pending in the irq_happened mask directly, rather than
    having the masked decrementer interupt handler do it. This will be
    replayed at the next local_irq_enable. See the comment for details.
    Signed-off-by: default avatarNicholas Piggin <npiggin@gmail.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    ebb37cf3
time.c 33.3 KB