• Johannes Berg's avatar
    mac80211: fix sta assignment · ec25acc4
    Johannes Berg authored
    I just had the following:
    WARNING: at drivers/net/wireless/iwlwifi/iwl-agn-tx.c:574 iwlagn_tx_skb+0x1576/0x15f0 [iwlagn]()
    Call Trace:
     <IRQ>  [<ffffffff8105c5df>] warn_slowpath_common+0x7f/0xc0
     [<ffffffff8105c63a>] warn_slowpath_null+0x1a/0x20
     [<ffffffffa0290b46>] iwlagn_tx_skb+0x1576/0x15f0 [iwlagn]
     [<ffffffffa027076c>] iwl_mac_tx+0x5c/0x260 [iwlagn]
     [<ffffffffa01bdf5b>] __ieee80211_tx+0x10b/0x1a0 [mac80211]
     [<ffffffffa01bfb86>] ieee80211_tx_pending+0x186/0x2d0 [mac80211]
     [<ffffffff81062ea5>] tasklet_action+0x125/0x130
     [<ffffffff810634a6>] __do_softirq+0x106/0x270
     [<ffffffff8100c09c>] call_softirq+0x1c/0x30
    iwlagn 0000:02:00.0: Attempting to modify non-existing station 107
    
    Note that 107 == 0x6b which is slab poison.
    
    The reason is that mac80211 passed a freed station
    pointer to mac80211, because as it happened iwlwifi
    reset itself while mac80211 was disconnecting from
    the network.
    
    It turns out that we do take care to look up the
    station pointer in ieee80211_tx_pending_skb, but
    then don't use it, which obviously is a bug. Fix
    this by removing the ieee80211_tx_h_sta handler
    and assigning the station pointer directly.
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    ec25acc4
tx.c 68.9 KB