• Andres Salomon's avatar
    [PATCH] Possible AMD8111e free irq issue · ecf4c2e1
    Andres Salomon authored
    It seems to me that if in the amd8111e_open() fuction dev->irq isn't
    zero and the irq request succeeds it might not get released anymore.
    
    Specifically, on failure of the amd8111e_restart() call the function
    returns -ENOMEM without releasing the irq. The amd8111e_restart()
    function can fail because of various pci_alloc_consistent() and
    dev_alloc_skb() calls in amd8111e_init_ring() which is being
    called by amd8111e_restart.
    
    1374     if(dev->irq ==0 || request_irq(dev->irq, amd8111e_interrupt, SA_SHIRQ,
    1375                      dev->name, dev))
    1376         return -EAGAIN;
    Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
    Signed-off-by: default avatarChris Wright <chrisw@osdl.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    ecf4c2e1
amd8111e.c 57 KB