• Steven Rostedt (VMware)'s avatar
    ftrace/direct: Do not disable when switching direct callers · ed292718
    Steven Rostedt (VMware) authored
    Currently to switch a set of "multi" direct trampolines from one
    trampoline to another, a full shutdown of the current set needs to be
    done, followed by an update to what trampoline the direct callers would
    call, and then re-enabling the callers. This leaves a time when the
    functions will not be calling anything, and events may be missed.
    
    Instead, use a trick to allow all the functions with direct trampolines
    attached will always call either the new or old trampoline while the
    switch is happening. To do this, first attach a "dummy" callback via
    ftrace to all the functions that the current direct trampoline is attached
    to. This will cause the functions to call the "list func" instead of the
    direct trampoline. The list function will call the direct trampoline
    "helper" that will set the function it should call as it returns back to
    the ftrace trampoline.
    
    At this moment, the direct caller descriptor can safely update the direct
    call trampoline. The list function will pick either the new or old
    function (depending on the memory coherency model of the architecture).
    
    Now removing the dummy function from each of the locations of the direct
    trampoline caller, will put back the direct call, but now to the new
    trampoline.
    
    A better visual is:
    
    [ Changing direct call from my_direct_1 to my_direct_2 ]
    
      <traced_func>:
         call my_direct_1
    
     ||||||||||||||||||||
     vvvvvvvvvvvvvvvvvvvv
    
      <traced_func>:
         call ftrace_caller
    
      <ftrace_caller>:
        [..]
        call ftrace_ops_list_func
    
    	ftrace_ops_list_func()
    	{
    		ops->func() -> direct_helper -> set rax to my_direct_1 or my_direct_2
    	}
    
       call rax (to either my_direct_1 or my_direct_2
    
     ||||||||||||||||||||
     vvvvvvvvvvvvvvvvvvvv
    
      <traced_func>:
         call my_direct_2
    
    Link: https://lore.kernel.org/all/20211014162819.5c85618b@gandalf.local.home/Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
    Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
    ed292718
ftrace.c 186 KB