• Finn Thain's avatar
    m68k/mac: Remove SHUTUP_SONIC interrupt hack · ed6344e1
    Finn Thain authored
    In macints.c there is some startup code which disables the SONIC interrupt
    in an attempt to avoid an unhandled slot interrupt, which would be fatal.
    This only works on those machines where the SONIC device is on-board.
    
    When the mac_sonic driver is built-in, there's little point in doing this,
    because the device will be initialized a few seconds later anyway. But
    when mac_sonic is a module, the window for an unhandled interrupt is
    longer.
    
    Either way, we've already run the gauntlet for 5 or 10 seconds by the time
    we get around to disabling this particular device. It's only by sheer luck
    that we got this far.
    
    Really, this is too little too late. The general problem of unhandled
    early interrupts also affects other devices on other models. There are
    better ways to resolve this problem.
    
    1) When using the Penguin bootloader, boot Mac OS with extensions disabled
       (by holding down the shift key at startup or by use of the Extensions
       Manager control panel). The Penguin docs already contain this advice,
       as it is always effective.
    
    2) Have the Penguin bootloader disable the device. It already attempts
       to disable slot interrupts. But since some hardware cannot mask slot
       interrupts, Penguin should probably close the relevant device
       drivers.
    
    3) Use Emile instead of Penguin. AFAIK the boot ROM never enables network
       device interrupts and hence they don't need to be disabled.
    
    Remove this hack. It requires maintenance and it doesn't solve the
    problem. It improves the odds for a few models, but so does setting
    CONFIG_MAC_SONIC=y.
    Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
    Reviewed-by: default avatarLaurent Vivier <laurent@vivier.eu>
    Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    ed6344e1
macints.c 6.61 KB