• Tuong Lien's avatar
    tipc: fix incorrect increasing of link window · edadedf1
    Tuong Lien authored
    In commit 16ad3f40 ("tipc: introduce variable window congestion
    control"), we allow link window to change with the congestion avoidance
    algorithm. However, there is a bug that during the slow-start if packet
    retransmission occurs, the link will enter the fast-recovery phase, set
    its window to the 'ssthresh' which is never less than 300, so the link
    window suddenly increases to that limit instead of decreasing.
    
    Consequently, two issues have been observed:
    
    - For broadcast-link: it can leave a gap between the link queues that a
    new packet will be inserted and sent before the previous ones, i.e. not
    in-order.
    
    - For unicast: the algorithm does not work as expected, the link window
    jumps to the slow-start threshold whereas packet retransmission occurs.
    
    This commit fixes the issues by avoiding such the link window increase,
    but still decreasing if the 'ssthresh' is lowered.
    
    Fixes: 16ad3f40 ("tipc: introduce variable window congestion control")
    Acked-by: default avatarJon Maloy <jmaloy@redhat.com>
    Signed-off-by: default avatarTuong Lien <tuong.t.lien@dektech.com.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    edadedf1
link.c 77.8 KB