• Michael Ellerman's avatar
    powerpc/kvm: Fix build error when PPC_MEM_KEYS/PPC_PSERIES=n · ee1bc694
    Michael Ellerman authored
    lkp reported a randconfig failure:
    
         In file included from arch/powerpc/include/asm/book3s/64/pkeys.h:6,
                        from arch/powerpc/kvm/book3s_64_mmu_host.c:15:
         arch/powerpc/include/asm/book3s/64/hash-pkey.h: In function 'hash__vmflag_to_pte_pkey_bits':
      >> arch/powerpc/include/asm/book3s/64/hash-pkey.h:10:23: error: 'VM_PKEY_BIT0' undeclared
            10 |  return (((vm_flags & VM_PKEY_BIT0) ? H_PTE_PKEY_BIT0 : 0x0UL) |
             |                       ^~~~~~~~~~~~
    
    We added the include of book3s/64/pkeys.h for pte_to_hpte_pkey_bits(),
    but that header on its own should only be included when PPC_MEM_KEYS=y.
    Instead include linux/pkeys.h, which brings in the right definitions
    when PPC_MEM_KEYS=y and also provides empty stubs when PPC_MEM_KEYS=n.
    
    Fixes: e4e8bc1d ("powerpc/kvm: Fix PR KVM with KUAP/MEM_KEYS enabled")
    Cc: stable@vger.kernel.org # v5.11+
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210425115831.2818434-1-mpe@ellerman.id.au
    ee1bc694
book3s_64_mmu_host.c 9.86 KB