• Thierry Vignaud's avatar
    [PATCH] checksatck.pl fixes · ee4a77fc
    Thierry Vignaud authored
    - "\<" and "\>" can be safely replaced with "<" and ">"
    
    - "$var =~ /^string$/" is better written "$var eq 'string'"
    
    - $i is better written without the double quotes
    
    - it's not safe to use for without "my"ing the iteration variable
    
    - "print foreach @array" is better written "print @array"
    
    - declare variables
    
    - ".*" is useless at the end of a regexp
    
    - "$a[@A] = $foo" is a rather obfuscated syntax for "push @A, $foo"...
      let's not opencoding language basic operators...
    
    - ignoring return value from a regexp is very bad: this can results in
      working on previous value of $1, $2, ...
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    ee4a77fc
checkstack.pl 2.74 KB