• Nathan Fontenot's avatar
    powerpc/pseries: Check for zero filled ibm,dynamic-memory property · 2c10636a
    Nathan Fontenot authored
    Some versions of QEMU will produce an ibm,dynamic-reconfiguration-memory
    node with a ibm,dynamic-memory property that is zero-filled. This
    causes the drmem code to oops trying to parse this property.
    
    The fix for this is to validate that the property does contain LMB
    entries before trying to parse it and bail if the count is zero.
    
      Oops: Kernel access of bad area, sig: 11 [#1]
      DAR: 0000000000000010
      NIP read_drconf_v1_cell+0x54/0x9c
      LR  read_drconf_v1_cell+0x48/0x9c
      Call Trace:
        __param_initcall_debug+0x0/0x28 (unreliable)
        drmem_init+0x144/0x2f8
        do_one_initcall+0x64/0x1d0
        kernel_init_freeable+0x298/0x38c
        kernel_init+0x24/0x160
        ret_from_kernel_thread+0x5c/0xb4
    
    The ibm,dynamic-reconfiguration-memory device tree property generated
    that causes this:
    
      ibm,dynamic-reconfiguration-memory {
              ibm,lmb-size = <0x0 0x10000000>;
              ibm,memory-flags-mask = <0xff>;
              ibm,dynamic-memory = <0x0 0x0 0x0 0x0 0x0 0x0>;
              linux,phandle = <0x7e57eed8>;
              ibm,associativity-lookup-arrays = <0x1 0x4 0x0 0x0 0x0 0x0>;
              ibm,memory-preservation-time = <0x0>;
      };
    Signed-off-by: default avatarNathan Fontenot <nfont@linux.vnet.ibm.com>
    Reviewed-by: default avatarCyril Bur <cyrilbur@gmail.com>
    Tested-by: default avatarDaniel Black <daniel@linux.vnet.ibm.com>
    [mpe: Trim oops report]
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    2c10636a
drmem.c 9.85 KB