• Steve Sistare's avatar
    mm/hugetlb: fix memfd_pin_folios resv_huge_pages leak · 26a8ea80
    Steve Sistare authored
    memfd_pin_folios followed by unpin_folios leaves resv_huge_pages elevated
    if the pages were not already faulted in.  During a normal page fault,
    resv_huge_pages is consumed here:
    
    hugetlb_fault()
      alloc_hugetlb_folio()
        dequeue_hugetlb_folio_vma()
          dequeue_hugetlb_folio_nodemask()
            dequeue_hugetlb_folio_node_exact()
              free_huge_pages--
          resv_huge_pages--
    
    During memfd_pin_folios, the page is created by calling
    alloc_hugetlb_folio_nodemask instead of alloc_hugetlb_folio, and
    resv_huge_pages is not modified:
    
    memfd_alloc_folio()
      alloc_hugetlb_folio_nodemask()
        dequeue_hugetlb_folio_nodemask()
          dequeue_hugetlb_folio_node_exact()
            free_huge_pages--
    
    alloc_hugetlb_folio_nodemask has other callers that must not modify
    resv_huge_pages.  Therefore, to fix, define an alternate version of
    alloc_hugetlb_folio_nodemask for this call site that adjusts
    resv_huge_pages.
    
    Link: https://lkml.kernel.org/r/1725373521-451395-4-git-send-email-steven.sistare@oracle.com
    Fixes: 89c1905d ("mm/gup: introduce memfd_pin_folios() for pinning memfd folios")
    Signed-off-by: default avatarSteve Sistare <steven.sistare@oracle.com>
    Acked-by: default avatarVivek Kasireddy <vivek.kasireddy@intel.com>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: Jason Gunthorpe <jgg@nvidia.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Muchun Song <muchun.song@linux.dev>
    Cc: Peter Xu <peterx@redhat.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    26a8ea80
hugetlb.c 214 KB