• Russell King's avatar
    mmc: sdhci: fix command response CRC error handling · ef78a0ce
    Russell King authored
    commit 71fcbda0 upstream.
    
    When we get a response CRC error on a command, it means that the
    response we received back from the card was not correct.  It does not
    mean that the card did not receive the command correctly.  If the
    command is one which initiates a data transfer, the card can enter the
    data transfer state, and start sending data.
    
    Moreover, if the request contained a data phase, we do not clean this
    up, and this results in the driver triggering DMA API debug warnings,
    and also creates a race condition in the driver, between running the
    finish_tasklet and the data transfer interrupts, which can trigger a
    "Got data interrupt" state dump.
    
    Fix this by handing a response CRC error slightly differently: record
    the failure of the data initiating command, but allow the remainder of
    the request to be processed normally.  This is safe as core MMC checks
    the status of all commands and data transfer phases of the request.
    
    If the card does not initiate a data transfer, then we should time out
    according to the data transfer parameters.
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    [ Fix missing parenthesis around bitwise-AND expression, and tweak subject ]
    Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
    Tested-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
    Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    ef78a0ce
sdhci.c 91.6 KB