• Uwe Kleine-König's avatar
    fbdev: omapfb/dvi: Don't put .remove() in .exit.text and drop suppress_bind_attrs · f004d911
    Uwe Kleine-König authored
    On today's platforms the memory savings of putting the remove function
    in .exit isn't that relevant any more. It only matters for built-in
    drivers and typically saves a few 100k.
    
    The downside is that the driver cannot be unbound at runtime which is
    ancient and also slightly complicates testing. Also it requires to mark
    the driver struct with __refdata which is needed to suppress a (W=1)
    modpost warning:
    
    	WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/connector-dvi: section mismatch in reference: dvi_connector_driver+0x4 (section: .data) -> dvic_remove (section: .exit.text)
    
    To simplify matters, move the remove callback to .text and drop
    .suppress_bind_attrs = true.
    Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    f004d911
connector-dvi.c 7.06 KB