• Linus Torvalds's avatar
    Merge tag 'vfs-5.10-fixes-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux · f01c30de
    Linus Torvalds authored
    Pull fs freeze fix and cleanups from Darrick Wong:
     "A single vfs fix for 5.10, along with two subsequent cleanups.
    
      A very long time ago, a hack was added to the vfs fs freeze protection
      code to work around lockdep complaints about XFS, which would try to
      run a transaction (which requires intwrite protection) to finalize an
      xfs freeze (by which time the vfs had already taken intwrite).
    
      Fast forward a few years, and XFS fixed the recursive intwrite problem
      on its own, and the hack became unnecessary. Fast forward almost a
      decade, and latent bugs in the code converting this hack from freeze
      flags to freeze locks combine with lockdep bugs to make this reproduce
      frequently enough to notice page faults racing with freeze.
    
      Since the hack is unnecessary and causes thread race errors, just get
      rid of it completely. Making this kind of vfs change midway through a
      cycle makes me nervous, but a large enough number of the usual
      VFS/ext4/XFS/btrfs suspects have said this looks good and solves a
      real problem vector.
    
      And once that removal is done, __sb_start_write is now simple enough
      that it becomes possible to refactor the function into smaller,
      simpler static inline helpers in linux/fs.h. The cleanup is
      straightforward.
    
      Summary:
    
       - Finally remove the "convert to trylock" weirdness in the fs freezer
         code. It was necessary 10 years ago to deal with nested
         transactions in XFS, but we've long since removed that; and now
         this is causing subtle race conditions when lockdep goes offline
         and sb_start_* aren't prepared to retry a trylock failure.
    
       - Minor cleanups of the sb_start_* fs freeze helpers"
    
    * tag 'vfs-5.10-fixes-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux:
      vfs: move __sb_{start,end}_write* to fs.h
      vfs: separate __sb_start_write into blocking and non-blocking helpers
      vfs: remove lockdep bogosity in __sb_start_write
    f01c30de
fs.h 112 KB